Skip to content

refactor: add full testing for debugbar:clear command#10093

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:full-test-debugbar-clear
Apr 9, 2026
Merged

refactor: add full testing for debugbar:clear command#10093
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:full-test-debugbar-clear

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
For 100% test coverage

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Apr 9, 2026
@paulbalandan paulbalandan merged commit 7fa1101 into codeigniter4:develop Apr 9, 2026
93 of 95 checks passed
@paulbalandan paulbalandan deleted the full-test-debugbar-clear branch April 9, 2026 20:07
@exec('which chattr', $whichOut, $whichRc);

if ($whichRc === 0) {
@exec(sprintf('sudo chattr +i %s', escapeshellarg($path)), $output, $rc);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulbalandan Does the command affect local tests, although I assume they should be executed for Docker/GithubAction?
As far as I know, you're testing on Windows and might not have seen it.
My tests are not automatic right now and are stopping.

Runtime:       PHP 8.5.5 with Xdebug 3.5.1
Configuration: /home/neznaika0/Coding/codeigniter/development/phpunit.dist.xml

.[sudo] password for root: 

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing on mac. The sudo is meant for GitHub Actions where it is a passwordless sudo.

I'll fix that. Thanks for raising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants